-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added daskgeopandas check to is_geodataframe
function
#1396
Conversation
Looks good to me! Just a minor addition. |
hvplot/tests/testutil.py
Outdated
import dask.dataframe as dd | ||
import spatialpandas as spd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thought are these can be moved up, and the pytest.mark.skipif can check if dd or spd is None.
import dask.dataframe as dd | |
import spatialpandas as spd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Done
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
+ Coverage 87.39% 88.80% +1.40%
==========================================
Files 50 51 +1
Lines 7490 7510 +20
==========================================
+ Hits 6546 6669 +123
+ Misses 944 841 -103 ☔ View full report in Codecov by Sentry. |
Thank you looks good now! |
Modified the
is_geodataframe
function to supportDaskGeoDataFrame
Test added.